Repository navigation
dashboard: say on the page when what it shows is stale - #216
Merged
Merged
Conversation
A read the server answers with its last good data (a slow run, or a failed one) now puts a note at the top: the time of what is shown, and that the page updates when the latest is ready. Fixed, so nothing under the cursor moves; over the content on a desktop and below the nav on a phone; clicks pass through it. A failure's banner replaces it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- It names the time of what is drawn, not of a read held while the owner types. - It gives way to a banner at the top, and sits under a drawer or review (z-index 19). - On a phone it sits below the nav as measured, not a fixed 60 px. - Its text is set only when it changes, so a screen reader isn't told again each poll. - Plainer copy, with the date when the data isn't from today. - The test checks it in one evaluation, with no assertion racing the next poll. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Reviewed: the owner asked for a visible cue while the page shows older data. It's a fixed note naming the drawn data's time, set as text only when it changes, pointer-events none, and it gives way to the failure and updated banners. Fable reviewed it, and its fixes are in. Dashboard tests pass on Node 24, including a phone-viewport Chrome test. CI 8/8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #214, at the owner's request. When the server answers with its last good data (a run over 20 s, or a failed one), the page used to show it with no cue beyond the sidebar's "updated" time, and that's hidden on phones.
What it adds
Tests. A new Chrome test runs on a phone viewport with `DEVTEAM_DATA_WAIT_MS=0`. It checks the note is shown inside the screen width, below the nav, and names the drawn data's time, all in one evaluation. Dashboard file on Node 24 locally: 114 pass, none failing. Checked by screenshot on phone (light) and desktop (dark).
Review. Fable did an adversarial review, and its fixes are in the last commit: the wrong time while data was held, a racy first-read assertion, floating over the drawer, overlapping banners, repeat screen-reader announcements, and the copy.
🤖 Generated with Claude Code